Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and Comments of the Incident Spec Doc #44

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

rpiazza
Copy link
Contributor

@rpiazza rpiazza commented Oct 13, 2023

No description provided.


[width="100%",cols="100%",stripes=odd]
|===
This new sdo extension *MUST* use [stixliteral]#extension-definition--4ca6de00-5b0d-45ef-a1dc-ea7279ea910e# as its extension ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removing this table formatting intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - unintentional :-(

Please don't merge this PR - it was for Jeff @dc3-tsd

@@ -244,9 +244,7 @@ This can be used to supplement the created_by_ref in cases where external author
<<<
[[event]]
=== 2.2. Event

[width="100%",cols="100%",stripes=odd]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore table formatting or the document does not properly build.

@@ -2662,4 +2682,4 @@ Added [stixliteral]#ransom-demand# and [stixliteral]#ransom-payment# to [stixtyp
|Richard Piazza and Jeffrey Mates
|Multiple editorial fixes, removing copy paste errors and obsolete relationships.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are public changes we should probably update the revision history.

@@ -310,21 +311,23 @@ This is typically used to indicate how an event has affected impacts.
|[stixtype]#{timestamp_url}[timestamp]#
|The date and time the event was last recorded. If this is not present it is assumed to be unknown.

If *start_time* and *end_time* properties are both defined, then end_time *MUST* be later than the start_time value.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"equal to or later than" or some other variation. Since we accept the usage of time fidelity it will be common to see the same value for both as many events, tasks, and impacts can be resolved in the same day they they started.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I copied that from somewhere in the STIX spec, but it should be "equal to or later than"

@rpiazza rpiazza merged commit 32c4b03 into oasis-open:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants